From 9437385628115c77969a04f56aa2279546292e26 Mon Sep 17 00:00:00 2001 From: Kristoffer Carlsson Date: Tue, 14 May 2024 03:17:02 +0200 Subject: [PATCH] remove `@test_nowarn` from tests (#62) This is too coarse and causes error for non-problematic printout to stderr (like precompile outputs). If there are certain warnings that are to be avoided, one should use `@test_logs` --- test/runtests.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index efc1c65..9116ab2 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -67,7 +67,7 @@ module TestJLL end # Package with a FileProduct Pkg.develop(PackageSpec(path=joinpath(@__DIR__, "Vulkan_Headers_jll"))) - @test_nowarn @eval TestJLL using Vulkan_Headers_jll + @eval TestJLL using Vulkan_Headers_jll @test @eval TestJLL Vulkan_Headers_jll.is_available() @test isfile(@eval TestJLL vk_xml) @test isfile(@eval TestJLL Vulkan_Headers_jll.vk_xml_path) @@ -88,7 +88,7 @@ module TestJLL end # Package with an ExecutableProduct Pkg.develop(PackageSpec(path=joinpath(@__DIR__, "HelloWorldC_jll"))) - @test_nowarn @eval TestJLL using HelloWorldC_jll + @eval TestJLL using HelloWorldC_jll @test @eval TestJLL HelloWorldC_jll.is_available() @test isfile(@eval TestJLL HelloWorldC_jll.hello_world_path) @test isfile(@eval TestJLL HelloWorldC_jll.get_hello_world_path()) @@ -117,7 +117,7 @@ module TestJLL end ) chmod(joinpath(libxlsreader_artifact_dir, "bin", "libxlsreader.dll"), 0o755) end - @test_nowarn @eval TestJLL using libxls_jll + @eval TestJLL using libxls_jll @test @eval TestJLL libxls_jll.is_available() @test isfile(@eval TestJLL libxls_jll.libxlsreader_path) @test isfile(@eval TestJLL libxls_jll.get_libxlsreader_path()) @@ -141,7 +141,7 @@ module TestJLL end # On 1.6 we lazyily download the missing artifact, causing output to stderr @eval TestJLL using LAMMPS_jll else - @test_nowarn @eval TestJLL using LAMMPS_jll + @eval TestJLL using LAMMPS_jll end if @eval TestJLL LAMMPS_jll.is_available() mpi_abi = @eval TestJLL LAMMPS_jll.augment_platform!(LAMMPS_jll.HostPlatform())["mpi"]