-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use .. from EllipsisNotation.jl #57
Conversation
Test failure on 1.0 appears to be caused by this list not being empty:
I think the offending line is this:
This list is not empty on 1.3 either, but that didn’t cause an error. I’m not entirely sure why this sees the package JSON at all. |
|
This looks fine for me, just bump the version number. |
Great! Is a minor increment enough, or should it go to 0.4? |
Definitely 0.4 |
The downside of this change is that EllipsisNotation.jl now depends on ArrayInterface.jl: https://github.com/ChrisRackauckas/EllipsisNotation.jl/blob/master/Project.toml So this adds around 5000 lines of code, not 20. If this package wants to stay lightweight, then we should consider reverting this. |
Yeah, that's not great. Let's deal with the issue over in SciML/EllipsisNotation.jl#25 |
This PR is reverted in #83, btw. |
Closes #18