-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert 1:ndims(X)
to ntuple(identity, ndims(X))
#97
Comments
jishnub
changed the title
Convert
Convert Mar 29, 2023
1:ndims(X)
to ntuple(identity, ndims(X)
1:ndims(X)
to ntuple(identity, ndims(X))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An example:
AbstractFFTs.jl/src/definitions.jl
Line 62 in a25656d
Using a
Tuple
here will allowndims
to be constant-propagated without relying on the compiler. It also reduces allocations in various functions, as vectors don't need to be allocated.Such a change would be mildly breaking, but seems worthwhile. FFTW has largely been updated to accept
Tuple
s as regions, and some other dependencies might need to be looked at.The text was updated successfully, but these errors were encountered: