Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ValidationManifold #217

Merged
merged 31 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
60d04f3
A first commit updating doc strings, adding the point.
kellertuer Nov 23, 2024
df8d3ae
accidentally deleted a line.
kellertuer Nov 23, 2024
9cc62ef
Trying to adapt converts – not yet fully successful.
kellertuer Nov 23, 2024
d5959a7
fix a tests.
kellertuer Nov 23, 2024
a32c28e
Runs formatter.
kellertuer Nov 23, 2024
24a4c0d
Fix conversion types.
kellertuer Nov 24, 2024
6cc6ce0
Start with the ignores dictionary.
kellertuer Nov 30, 2024
d5712ca
Add the ignore dictionary and test it prototypically on one function.
kellertuer Nov 30, 2024
c9313d4
Rework how to store ignores and a nicer dispatch.
kellertuer Dec 1, 2024
180fda9
Add new scheme to all is_point and is_vector calls.
kellertuer Dec 1, 2024
0bdce6c
Fix tests.
kellertuer Dec 2, 2024
15697aa
Unify _msg, add functions from the interface file.
kellertuer Dec 2, 2024
d956042
make _msg also handle errors, hence tests pass again, where two error…
kellertuer Dec 2, 2024
d12b3fe
Debugging and Test coverage.
kellertuer Dec 2, 2024
a8bbc1f
minor fix
mateuszbaran Dec 2, 2024
9cc2e6b
A bit more test coverage.
kellertuer Dec 2, 2024
bc296c3
A few final tests for today.
kellertuer Dec 2, 2024
dcf2773
Discard part that is (due to previous dispatched) no longer necessary.
kellertuer Dec 2, 2024
ea9de3b
Remove a few prefx emojis.
kellertuer Dec 7, 2024
5a22a53
code coverage and discuccions from review.
kellertuer Dec 7, 2024
35a8ecd
Follow the same scheme as Manifolds.jl and make LTS (1.10) the lower …
kellertuer Dec 7, 2024
30aef05
Remove dependency on Requires.jl, since we raised LTS.
kellertuer Dec 7, 2024
ccea1e8
improve test to be a bit more silent.
kellertuer Dec 7, 2024
3e09b79
prepare for logo prefixes here as well.
kellertuer Dec 7, 2024
e822729
fix a typo in a filename.
kellertuer Dec 7, 2024
b075bcb
small improvements
mateuszbaran Dec 9, 2024
2efe152
add two missing tests
mateuszbaran Dec 9, 2024
161d00d
promote base points on new TVectors.
kellertuer Dec 9, 2024
06e4414
also update existing base points if a vector is mutated.
kellertuer Dec 9, 2024
44c4b8a
improve test cov.
kellertuer Dec 9, 2024
51dbfa6
fix two within
mateuszbaran Dec 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.15.23]

### Added

* a field `point` to `ValidationFibreVector` to store potentially store the point of the vector.
* a field `store_base_point` to `ValidationManifold` to indicate whether for new fibre vectors the base point should be stored.

### Changed

* the internal function `_array_value` was renamed to `_value`,
kellertuer marked this conversation as resolved.
Show resolved Hide resolved
since the cases where it is used also work for non-array poins/vectors

## [0.15.22] 15/11/2024

### Added
Expand Down
Loading
Loading