-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointless norm on vector fibers #209
Conversation
Oh, I'm not sure if we can have that: norm(itr, p::Real) @ LinearAlgebra /opt/hostedtoolcache/julia/1.10.5/x64/share/julia/stdlib/v1.10/LinearAlgebra/src/generic.jl:595
norm(M::ManifoldsBase.VectorSpaceFiber{𝔽} where 𝔽, X) @ ManifoldsBase ~/work/ManifoldsBase.jl/ManifoldsBase.jl/src/VectorFiber.jl:11 Especially after #206 . |
My local testing indicates that it doesn't break anything in Manifolds.jl. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 31 31
Lines 3398 3399 +1
=======================================
+ Hits 3396 3397 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
± the small improvement that this is a bugfix actually, this all looks good.
Co-authored-by: Ronny Bergmann <[email protected]>
Implements the feature discussed here: JuliaManifolds/LieGroups.jl#8 (comment) .