Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typos #218

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Small typos #218

merged 2 commits into from
Nov 27, 2024

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Nov 27, 2024

Hi,

I was reading through the manual and simultaneously fixed a couple typos.
Just as a small remark, one of the changes is not just a typo, but I slightly reworded the sentence because it was a bit confusing to me. If you prefer not to have this, let me know and I'll change it back

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (e116010) to head (d85809c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          31       31           
  Lines        3401     3401           
=======================================
  Hits         3399     3399           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer
Copy link
Member

Thanks, this looks great. And yes, we only slowly work through old code and use more spellcheckers, so any fix of typos is super welcome – thanks for reporting them!

@kellertuer kellertuer merged commit 65ddbfc into JuliaManifolds:master Nov 27, 2024
13 of 14 checks passed
@lkdvos
Copy link
Contributor Author

lkdvos commented Nov 27, 2024

My pleasure, I have the exact same problem for my own packages and always really appreciate when someone just fixes typos as they go

@lkdvos lkdvos deleted the ld-typos branch November 27, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants