Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify use of an atol when comparing to zero #692

Merged
merged 29 commits into from
Dec 25, 2023

Revert deletion of two methods of `parallel_transport_direction` and …

f95584f
Select commit
Loading
Failed to load commit list.
Refresh
Merged

Unify use of an atol when comparing to zero #692

Revert deletion of two methods of `parallel_transport_direction` and …
f95584f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 24, 2023 in 1s

11.85% of diff hit (target 99.57%)

View this Pull Request on Codecov

11.85% of diff hit (target 99.57%)

Annotations

Check warning on line 38 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L38 

Added line #L38 was not covered by tests

Check warning on line 45 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L45 

Added line #L45 was not covered by tests

Check warning on line 64 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L64 

Added line #L64 was not covered by tests

Check warning on line 72 in src/manifolds/CenteredMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CenteredMatrices.jl#L72 

Added line #L72 was not covered by tests

Check warning on line 31 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L31 

Added line #L31 was not covered by tests

Check warning on line 39 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L39 

Added line #L39 was not covered by tests

Check warning on line 62 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L62 

Added line #L62 was not covered by tests

Check warning on line 69 in src/manifolds/CholeskySpace.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/CholeskySpace.jl#L69 

Added line #L69 was not covered by tests

Check warning on line 169 in src/manifolds/Circle.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Circle.jl#L169 

Added line #L169 was not covered by tests

Check warning on line 88 in src/manifolds/Elliptope.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Elliptope.jl#L88 

Added line #L88 was not covered by tests

Check warning on line 97 in src/manifolds/Elliptope.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Elliptope.jl#L97 

Added line #L97 was not covered by tests

Check warning on line 128 in src/manifolds/EssentialManifold.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/EssentialManifold.jl#L128 

Added line #L128 was not covered by tests

Check warning on line 135 in src/manifolds/EssentialManifold.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/EssentialManifold.jl#L135 

Added line #L135 was not covered by tests

Check warning on line 119 in src/manifolds/Euclidean.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Euclidean.jl#L117-L119 

Added lines #L117 - L119 were not covered by tests

Check warning on line 531 in src/manifolds/Euclidean.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Euclidean.jl#L531 

Added line #L531 was not covered by tests

Check warning on line 544 in src/manifolds/Euclidean.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Euclidean.jl#L538-L544 

Added lines #L538 - L544 were not covered by tests

Check warning on line 546 in src/manifolds/Euclidean.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Euclidean.jl#L546 

Added line #L546 was not covered by tests

Check warning on line 556 in src/manifolds/Euclidean.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Euclidean.jl#L554-L556 

Added lines #L554 - L556 were not covered by tests

Check warning on line 569 in src/manifolds/Euclidean.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Euclidean.jl#L562-L569 

Added lines #L562 - L569 were not covered by tests

Check warning on line 327 in src/manifolds/FixedRankMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/FixedRankMatrices.jl#L327 

Added line #L327 was not covered by tests

Check warning on line 335 in src/manifolds/FixedRankMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/FixedRankMatrices.jl#L335 

Added line #L335 was not covered by tests

Check warning on line 341 in src/manifolds/FixedRankMatrices.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/FixedRankMatrices.jl#L341 

Added line #L341 was not covered by tests

Check warning on line 283 in src/manifolds/GeneralizedGrassmann.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/GeneralizedGrassmann.jl#L283 

Added line #L283 was not covered by tests

Check warning on line 174 in src/manifolds/Grassmann.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Grassmann.jl#L174 

Added line #L174 was not covered by tests

Check warning on line 335 in src/manifolds/Hyperbolic.jl

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/manifolds/Hyperbolic.jl#L335 

Added line #L335 was not covered by tests
View more details on Codecov