Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as_df=false requires using DataFrames #184

Open
pedromxavier opened this issue Oct 26, 2022 · 1 comment · May be fixed by #185
Open

as_df=false requires using DataFrames #184

pedromxavier opened this issue Oct 26, 2022 · 1 comment · May be fixed by #185

Comments

@pedromxavier
Copy link

When running

julia> using MLDatasets: Iris

julia> X, y = Iris(as_df=false)[:]

on julia 1.8.2, MLDatasets v0.7.5 the user is prompted with an error asking for DataFrames to be installed.
@CarloLucibello CarloLucibello linked a pull request Oct 27, 2022 that will close this issue
Open
@CarloLucibello
Copy link
Member

That is intended behavior since in the constructor we do some intermediate manipulations using dataframes for convenience, but with a little additional effort that can be avoided (fix in #185)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not require DataFrames.jl when output doesn't contain DataFrames JuliaML/MLDatasets.jl
2 participants
@CarloLucibello @pedromxavier