Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform keyword to dataset constructors to store a transformation #138

Open
CarloLucibello opened this issue May 28, 2022 · 3 comments

Comments

@CarloLucibello
Copy link
Member

Both HuggingFace and torchvision's datasets can store a transformation that is applied on the fly when indexing a dataset.
I think this is generally very convenient and we should add it to every dataset.

@lorenzoh
Copy link
Contributor

I feel it may be cleaner to tell users to use mapobs and give some examples. AFAICT there would be no functional difference, right?

@CarloLucibello
Copy link
Member Author

Yes maybe there is no advantage over a mapobs. I'll keep the issue open until we add some examples in the docs.

@CarloLucibello
Copy link
Member Author

The recently introduced TorchData could be a source of inspiration
https://pytorch.org/data/beta/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants