Allow passing an initial partial Schur decomposition #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 95.91% 96.75% +0.83%
==========================================
Files 10 10
Lines 856 800 -56
==========================================
- Hits 821 774 -47
+ Misses 35 26 -9 ☔ View full report in Codecov by Sentry. |
haampie
force-pushed
the
fix/pre-allocate-workspace
branch
from
71bb9ea
to
11c0e07
Compare
haampie
force-pushed
the
fix/pre-allocate-workspace
branch
from
11c0e07
to
0be7991
Compare
haampie
added a commit
that referenced
this pull request
Feb 22, 2024
This commit allows users to 1. avoid allocations by reusing existing arrays/buffers 2. specify custom matrix types for V, H and temporaries 3. starting the algorithm from an existing partial Schur decomposition by exporting `ArnoldiWorkspace`, which holds the major arrays, and `partialschur!(A, ::ArnoldiWorkspace; ...)`. Co-authored-by: Samuel Powell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to
by exporting
ArnoldiWorkspace, which holds the major arrays, andpartialschur!(A, ::ArnoldiWorkspace; ...).