Support starting vec #141
Merged
Support starting vec #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 95.73% 96.69% +0.95%
==========================================
Files 10 10
Lines 845 787 -58
==========================================
- Hits 809 761 -48
+ Misses 36 26 -10 ☔ View full report in Codecov by Sentry. |
haampie
added a commit
that referenced
this pull request
Feb 22, 2024
Adds a keyword arg `partialschur(...; v1)` which the vector that induces the Krylov subspace. Co-authored-by: Samuel Powell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
This allows
Just
V,V_tmp,HandQare inArnoldiWorkspace. Further allocations are one-dimensional and tiny (and actually the householder reflector can be computed in-place in H now #139 is merged)As a follow-up,
partialschur(A, ::ArnoldiWorkspace)could be implemented to let users allocate themselves, which is also useful for supporting GPU arrays. I think easiest would be with unified memory, cause then I don't really have to sprinkle copies to and from GPU around.