Purging: remove converged, unwanted vecs #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 95.47% 95.52% +0.05%
==========================================
Files 10 10
Lines 839 849 +10
==========================================
+ Hits 801 811 +10
Misses 38 38 ☔ View full report in Codecov by Sentry. |
haampie
force-pushed
the
fix/purge-converged-unwanted
branch
from
ba3a7e1
to
9fd7e67
Compare
Closed
haampie
added a commit
that referenced
this pull request
Feb 18, 2024
It looks like converged, unwanted vectors can actually be problematic for the Krylov-Schur restart, since they have tiny residuals, and we need to construct reflectors out of those values. By reordering the converged, unwanted to the tail of the decomposition, they're removed, and we don't have to compute reflectors involving their residuals. Should also restore the original pre-0.3 behavior of purging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like converged, unwanted vectors can actually be problematic for the
Krylov-Schur restart, since they have tiny residuals, and we need to construct
reflectors out of those values.
By reordering the converged, unwanted to the tail of the decomposition, they're
removed, and we don't have to compute reflectors involving their residuals.