Fix bug where number type in stopping criterion was derived from tol instead of real(eltype(H))
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` instead of real(eltype(H))
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 95.21% 95.22%
=======================================
Files 10 10
Lines 815 816 +1
=======================================
+ Hits 776 777 +1
Misses 39 39 ☔ View full report in Codecov by Sentry. |
haampie
commented
Feb 17, 2024
haampie
added a commit
that referenced
this pull request
Feb 17, 2024
…` instead of real(eltype(H)) (#137) Previously ArnoldiMethod.jl would accidentially pick `eps(typeof(tol))` instead `eps(real(typeof(residual)))` So, with bigfloat and tol = 1e-30 you would actually just get eps(Float64) accuracy, whereas `tol = big(1e-30)` would have given the requested tolerance. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ArnoldiMethod.jl would accidentially pick
eps(typeof(tol))insteadeps(real(typeof(residual)))So, with bigfloat and tol = 1e-30 you would actually just get eps(Float64) accuracy, whereas
tol = big(1e-30)would have given the requested tolerance.This fixes that.