Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 [master] Bump the SHA stdlib from aaf2df6 to 0b76d04 #56829

Conversation

DilumAluthgeBot
Copy link
Contributor

Stdlib: SHA
URL: https://github.com/JuliaCrypto/SHA.jl.git
Stdlib branch: master
Julia branch: master
Old commit: aaf2df6
New commit: 0b76d04
Julia version: 1.12.0-DEV
SHA version: 0.7.0(Does not match)
Bump invoked by: @DilumAluthge
Powered by: BumpStdlibs.jl

Diff: JuliaCrypto/SHA.jl@aaf2df6...0b76d04

$ git log --oneline aaf2df6..0b76d04
0b76d04 Merge pull request #114 from JuliaCrypto/dependabot/github_actions/codecov/codecov-action-5
5094d9d Update .github/workflows/CI.yml
45596b1 Bump codecov/codecov-action from 4 to 5
230ab51 test: remove outdate tests (#113)
7f25aa8 rm: Duplicated const alias (#111)
aa72f73 [SHA3] Fix padding special-case (#108)
3a01401 Delete Manifest.toml (#109)
da351bb Remvoe all getproperty funcs (#99)
4eee84f Bump codecov/codecov-action from 3 to 4 (#104)
15f7dbc Bump codecov/codecov-action from 1 to 3 (#102)
860e6b9 Bump actions/checkout from 2 to 4 (#103)
8e5f0ea Add dependabot to auto update github actions (#100)
4ab324c Merge pull request #98 from fork4jl/sha512-t
a658829 SHA-512: add ref to NIST standard
11a4c73 Apply suggestions from code review
969f867 Merge pull request #97 from fingolfin/mh/Vector
b1401fb SHA-512: add NIST test
4d7091b SHA-512: add to docs
09fef9a SHA-512: test SHA-512/224, SHA-512/256
7201b74 SHA-512: impl SHA-512/224, SHA-512/256
4ab85ad Array -> Vector
8ef91b6 fixed bug in padding for shake, addes testcases for full code coverage (#95)
88e1c83 Remove non-existent property (#75)
068f85d shake128,shake256: fixed typo in export declarations (#93)
176baaa SHA3 xof shake128 and shake256  (#92)
e1af7dd Hardcode doc edit backlink

@DilumAluthge DilumAluthge added the stdlib Julia's standard library label Dec 14, 2024
@inkydragon inkydragon added the merge me PR is reviewed. Merge when all tests are passing label Dec 14, 2024
@inkydragon
Copy link
Member

Seems to be a bug in the SHA, not sure why the SHA´s ci doesn´t catch it.

Error During Test at /cache/build/tester-amdci4-11/julialang/julia-master/julia-7294acd59f/share/julia/stdlib/v1.12/SHA/test/runtests.jl:180
  Test threw exception
  Expression: SHA.shake256(hex2bytes(k[1]), k[2]) == hex2bytes(v)
  MethodError: no method matching digest!(::SHA.SHAKE_256_CTX, ::UInt64, ::Ptr{UInt8})
  The function `digest!` exists, but no method is defined for this combination of argument types.
  Closest candidates are:
    digest!(::T, !Matched::UInt32, ::Ptr{UInt8}) where T<:SHA.SHAKE
     @ SHA /cache/build/tester-amdci4-11/julialang/julia-master/julia-7294acd59f/share/julia/stdlib/v1.12/SHA/src/shake.jl:73

@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Dec 14, 2024
Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for an SHA.jl update

@inkydragon
Copy link
Member

We need a new bump include JuliaCrypto/SHA.jl#117

@inkydragon
Copy link
Member

Replaced by #56834

@inkydragon inkydragon closed this Dec 14, 2024
@DilumAluthge DilumAluthge deleted the BumpStdlibs/SHA-0b76d04-master branch December 14, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants