gc: improve mallocarrays locality #56801
Merged
+31
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
reviewed
Dec 11, 2024
vtjnash
force-pushed
the
jn/mallocarrays-list
branch
from
8afa0e6 to
725adba
Compare
gbaraldi
approved these changes
Dec 11, 2024
|
This seems to fix #56759 for me. So we probably want to backport this |
IIRC we're still using this data structure in 1.10. If this is indeed a source of a memory leak, then we should consider backporting it to 1.10 as well. |
vtjnash
force-pushed
the
jn/mallocarrays-list
branch
3 times, most recently
from
ed028da to
b02629a
Compare
small_arraylist_t has much better memory locality and space utilization than a linked list with individually malloc'd elements. However, seemed that it needed alignment of small_arraylist_t to both hold all elements the user might create and avoid gcc bugs.
vtjnash
force-pushed
the
jn/mallocarrays-list
branch
from
b02629a to
6e2c0cb
Compare
|
Can confirm this fixes #56759. Nice work! |
|
Do we know why it fixes the memory leak? Were we simply not freeing the elements of the linked list? |
|
yes |
|
No idea |
|
Could this also be backported to 1.10? |
oscardssmith
added
the
backport 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small_arraylist_t has much better memory locality and space utilization than a linked list with individually malloc'd elements