Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jldoctest setup for permutedims #56797

Closed
wants to merge 3 commits into from

Conversation

ErikQQY
Copy link

@ErikQQY ErikQQY commented Dec 11, 2024

setup = :(using LinearAlgebra) break the docs in REPL, also we don't need using LinearAlgebra in the doctest(transpose already in Base)

image

@ErikQQY
Copy link
Author

ErikQQY commented Dec 11, 2024

OK, this seems to only happen on MacOS🤔

@inkydragon
Copy link
Member

inkydragon commented Dec 11, 2024

You need to update REPL output too.
https://buildkite.com/julialang/julia-master/builds/42925#0193b485-79d8-4348-8a02-34d126799602/824-889

│ Subexpression:
│ 
│ typeof(r)
│ 
│ Evaluated output:
│ 
│ LinearAlgebra.Transpose{Int64, Vector{Int64}}
│ 
│ Expected output:
│ 
│ Transpose{Int64, Vector{Int64}}
│ 
│   diff = Transpose{Int64, LinearAlgebra.Transpose{Int64, Vector{Int64}}

Without using LinearAlgebra, we have:

julia> transpose(X)
2×2 transpose(::Matrix{Matrix{Int64}}) with eltype LinearAlgebra.Transpose{Int64, Matrix{Int64}}:
 [1 3; 2 4]  [9 11; 10 12]
 [5 7; 6 8]  [13 15; 14 16]


julia> using LinearAlgebra

julia> transpose(X)
2×2 transpose(::Matrix{Matrix{Int64}}) with eltype Transpose{Int64, Matrix{Int64}}:
 [1 3; 2 4]  [9 11; 10 12]
 [5 7; 6 8]  [13 15; 14 16]

I guess it's to make the output cleaner.

@inkydragon inkydragon added the docs This change adds or pertains to documentation label Dec 11, 2024
@ErikQQY
Copy link
Author

ErikQQY commented Dec 11, 2024

You need to update REPL output too.

Fixed

@LilithHafner
Copy link
Member

I'm not sure what this fixes; is help mode broken for this docstring on mac?

@KristofferC
Copy link
Member

I think this is just exposing a bug in OhMyREPL (the missing julia> prompts) and the change should thus be made there.

@ErikQQY
Copy link
Author

ErikQQY commented Dec 12, 2024

Oh, this issue is related to OhMyREPL, I will make changes there

@ErikQQY ErikQQY closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants