Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping download of lazy artifacts #464

Closed
rbvermaa opened this issue Oct 23, 2020 · 5 comments
Closed

Allow skipping download of lazy artifacts #464

rbvermaa opened this issue Oct 23, 2020 · 5 comments

Comments

@rbvermaa
Copy link
Contributor

rbvermaa commented Oct 23, 2020

When using PackageCompiler.jl, we ran into an issue with TimeZone.jl [0] where it downloaded all timezone data (200+ files). These files are listed as lazy. We would like to avoid downloading them, and in the issue linked, it was mentioned we should probably add an include_lazy_artifacts option.

I tried to add an include_lazy_artifacts option [1], however, it is probably not a correct solution, as it ignores the situation where there is a Dict in the Artifact section. See first part of the if at https://github.com/RelationalAI-oss/PackageCompiler.jl/blob/rv-include-lazy/src/PackageCompiler.jl#L722 .

This patch, although probably incorrect, solved our immediate issue (we ger blocked by the server when downloading too many files).

I think this probably only can be fixed in Pkg.jl, but not sure how. Any idea how to get this fixed properly?

[0] JuliaTime/TimeZones.jl#300
[1] master...RelationalAI-oss:rv-include-lazy

@NHDaly
Copy link
Member

NHDaly commented Dec 1, 2020

CC: @staticfloat - i think we talked with you and @KristofferC about this on slack. Do you think something like an include_lazy_artifacts option is the best approach? Should it be along the lines of @rbvermaa's patch, above?

Thanks!

@KristofferC
Copy link
Sponsor Member

It makes sense to me to have that option, at least.

@IanButterworth
Copy link
Sponsor Member

This is quite painful for CUDA.jl given all of the many large artifacts are lazy https://github.com/JuliaGPU/CUDA.jl/blob/master/Artifacts.toml

And a include_lazy_artifacts flag wouldn't help here, I believe. I think PackageCompiler will need to know which lazy artifacts it needs to grab in advance

@Sacha0
Copy link
Member

Sacha0 commented Jan 7, 2021

Bumping as this issue bit us again just now. Given

It makes sense to me to have that option, at least.

I'll roll Rob's branch into a pull request so that we can begin iterating something. Thanks folks! :)

@KristofferC
Copy link
Sponsor Member

This is now merged into PackageCompiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants