From c066726320b4d673b4487a22a2ddc3edc491fb49 Mon Sep 17 00:00:00 2001 From: Jeff Fessler Date: Sat, 18 May 2024 10:11:47 -0400 Subject: [PATCH] Fix ext args (#67) * Fix ext args * Add CODECOV_TOKEN --- .github/workflows/ci.yml | 2 ++ ext/sino-plot.jl | 1 - src/exts.jl | 8 ++++---- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 25db0c6..cb93ff8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,3 +38,5 @@ jobs: if: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' }} with: file: lcov.info + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} diff --git a/ext/sino-plot.jl b/ext/sino-plot.jl index 8c68874..75f710c 100644 --- a/ext/sino-plot.jl +++ b/ext/sino-plot.jl @@ -19,7 +19,6 @@ Make a scatter plot of the `(r, ϕ)` sample locations for all rays. Needs `Plots`. """ function sino_plot_rays(rg::SinoGeom; kwargs...) -# r, phi = rays(rg) i = rays(rg) r = [i[1] for i in i] ϕ = [i[2] for i in i] diff --git a/src/exts.jl b/src/exts.jl index 29fe0ab..0a4af58 100644 --- a/src/exts.jl +++ b/src/exts.jl @@ -4,8 +4,8 @@ export sino_plot_rays, sino_geom_plot! export ct_geom_plot2!, ct_geom_plot3 -sino_plot_rays(::Nothing) = throw("Run `using Plots` first") -sino_geom_plot!(::Nothing) = throw("Run `using Plots` first") +sino_plot_rays(args...; kwargs...) = throw("First run `using Plots`") +sino_geom_plot!(args...; kwargs...) = throw("First run `using Plots`") -ct_geom_plot2!(::Nothing) = throw("Run `using Plots` first") -ct_geom_plot3(::Nothing) = throw("Run `using Plots` first") +ct_geom_plot2!(args...; kwargs...) = throw("First run `using Plots`") +ct_geom_plot3(args...; kwargs...) = throw("First run `using Plots`")