Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ADMM verbose doesn't work anymore #93

Closed
SebastianFlassbeck opened this issue Aug 13, 2024 · 5 comments
Closed

[Bug] ADMM verbose doesn't work anymore #93

SebastianFlassbeck opened this issue Aug 13, 2024 · 5 comments

Comments

@SebastianFlassbeck
Copy link
Contributor

If ADMM is run with verbose = true, it throws an error in line 207 in ADMM.jl since the variable iteration doesn't exist.
I'm guessing that state.iteration instead, should fix it but I didn't look through the code thoroughly.

@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

Yes that should fix it. I can push that change to master but the earliest time I can do that is in 2+ days

@nHackel
Copy link
Member

nHackel commented Aug 13, 2024

Maybe a more fundamental question is if we can replace verbose with some callback that has verbose printing for each solver or if we can replace verbose with Julias logging system.

I havent used the keyword yet, so Im not sure whats the most convenient from a user perspective. Do you have a preference?

Or maybe @JakobAsslaender you have one?

I could maybe sketch up verbosecallback in the next week

@JakobAsslaender
Copy link
Member

Hmm, my first instinct is that a callback is a rather complicated way of printing some convergence measures. Beyond this first instinct, I would try and keep it similar to other packages, but I would need look into the common practices.

@SebastianFlassbeck
Copy link
Contributor Author

Thanks. I don't have any preferences. FYI, the outputs in lines 267-271 also need a state..

@nHackel nHackel closed this as completed Aug 23, 2024
@nHackel
Copy link
Member

nHackel commented Aug 23, 2024

Should be fixed with the latest (currently being released) version. I've also added tests for the verbose keyword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants