From 35f9f0ffb091f77851a8b24856bed49db41a531b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= Date: Thu, 14 Mar 2024 23:22:56 +0000 Subject: [PATCH 1/4] [CI] Test with Poplar 3.3 --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 00d6fb9..cfdf2d8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,6 +24,9 @@ jobs: - julia_version: "1.10" docker_image: graphcore/poplar:3.2.0-ubuntu-20.04-20230314 build_docs: true + - julia_version: "^1.11.0-0" + docker_image: graphcore/poplar:3.3.0-ubuntu-20.04-20230703 + build_docs: false steps: - name: "Install, g++, git, jq" # g++ is needed to build the wrapper, git to publish the docs, jq for From 9e0f00262b5d798df25aea0311695065073f4a46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= Date: Tue, 9 Apr 2024 01:30:04 +0100 Subject: [PATCH 2/4] [CI] Explicitly export environment variables --- .github/workflows/ci.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cfdf2d8..cd069dd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,6 +57,19 @@ jobs: cache-artifacts: "true" cache-packages: "true" cache-compiled: "true" + - name: "Export environment variables" + # Starting from graphcore/poplar:3.3.0 some environment variables like `CPATH` and + # `LD_LIBRARY_PATH`, which we need for building the bindings, are only set with the + # `bash` shell, while GHA uses by default `sh` for steps inside containers. So we + # need to start a step with `shell: bash` and re-export the relevant variables for + # the following steps. + shell: bash + run: | + echo "PATH=${PATH}" >> "${GITHUB_ENV}" + echo "CPATH=${CPATH}" >> "${GITHUB_ENV}" + echo "LIBRARY_PATH=${LIBRARY_PATH}" >> "${GITHUB_ENV}" + echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH}" >> "${GITHUB_ENV}" + echo "POPLAR_SDK_ENABLED=${POPLAR_SDK_ENABLED}" >> "${GITHUB_ENV}" - uses: julia-actions/julia-buildpkg@v1 env: CXX: g++ From dd818fd4e8f608118e499cb4a89f934fd34bf449 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= Date: Tue, 9 Apr 2024 12:07:00 +0100 Subject: [PATCH 3/4] Only run with Poplar v3.3.0 for the time being, for testing --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cd069dd..67132f7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,12 +18,12 @@ jobs: fail-fast: false matrix: include: - - julia_version: "1.9" - docker_image: graphcore/poplar:2.5.1-ubuntu-20.04-20220629 - build_docs: false - - julia_version: "1.10" - docker_image: graphcore/poplar:3.2.0-ubuntu-20.04-20230314 - build_docs: true + # - julia_version: "1.9" + # docker_image: graphcore/poplar:2.5.1-ubuntu-20.04-20220629 + # build_docs: false + # - julia_version: "1.10" + # docker_image: graphcore/poplar:3.2.0-ubuntu-20.04-20230314 + # build_docs: true - julia_version: "^1.11.0-0" docker_image: graphcore/poplar:3.3.0-ubuntu-20.04-20230703 build_docs: false From 9f03bd1f782405155eec53517e8d1d2272605ef7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= Date: Tue, 9 Apr 2024 12:07:42 +0100 Subject: [PATCH 4/4] [CI] Only declare git repo safe when building docs --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 67132f7..e3db80c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,6 +38,7 @@ jobs: DEBIAN_FRONTEND: noninteractive - uses: actions/checkout@v4 - name: "Declare git repo safe" + if: ${{ matrix.build_docs }} # In the docker container the repo is owned by 1001:123, causing the # following error when running git commands: #