Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreliable warning when reading #69

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Remove unreliable warning when reading #69

merged 1 commit into from
Aug 29, 2024

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Aug 29, 2024

"I don't want everyone to pay the performance cost of Apple's incompetence/hostility if they don't want to"
Ref: thejoshwolfe/yauzl#69

macOS Archive Utility sometimes lies about how many entries are in the central directory.

I had some code to try and detect this and log a warning. However, logging a warning is not part of the zip spec, may be unexpected, and was causing JET to complain.

This PR removes this warning.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (301fb33) to head (13b4615).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files           6        6              
  Lines         784      780       -4     
==========================================
- Hits          781      777       -4     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2 nhz2 merged commit 07b6381 into main Aug 29, 2024
20 checks passed
@nhz2 nhz2 deleted the remove-warning branch August 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant