Fix significant performance regression #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generalising
ClusterSequence
to also handle theEEJet
type, thejets
member was changed to be the abstract typeFourMomentum
. This is type unstable and has a very negative impact on performance!Fix
ClusterSequence
to be parameterised, where the typeT
is taken from the type of the jets passed in to the constructor.This improves performance for$pp$ and $e^+e^-$ significantly.
Further fixes are to factorise out some of the
StructArray
handling functions inEEAlgorithm.jl
to make the code logic easier to follow.