Add support for EDM4hep inputs #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jet class constructors (EEjet, Pseudojet) were typed to Float64, which is too narrow. Now retype to Real (which in particular allows passing in Float32s).
Accessors px, py, pz, energy for EDM4hep reconstructed particles Allow direct construction of internal jet structs from a reco particle This extension only activated if EDM4hep is loaded in the environment
Simple example of how to run jet reconstruction from an EDM4hep input file
There is no need that the input particles be explicitly a vector, in fact from EDM4hep files one gets a StructArrays.StructVector, which is a subtype of AbstractArray. This allows jet reconstruction directly from the ReconstructedParticles object of EDM4hep, without needing to copy the data into another container.
Overcomes compatibility issues with EDM4hep via FHist
Remove Vitepress formatting from documentation as it is impossible to preview correctly locally (even with suggested work arounds). Add documentation to the EDM4hep extension file.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Going to merge this PR now, but TODO is to add a test with a small EDM4hep ROOT file (and generally work on code coverage in the tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extension that allows
ReconstructedParticlesto be read from EDM4hep files.Ensure that internal jet objects can be initialised from any
Real, not justFloat64(which is too restrictive!).For input particle collections, type to
AbstractArray{T, 1}instead ofVector{T}, so that alternative containers can be used (specificallyStructArrays.StructVectorfrom EDM4hep).Add documentation updates for this change. Unfortunately also retreat from Vitepress as it seems to completely screw up the ability to preview changes locally (locally generated pages are just broken).
Closes #79