You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the examples are distributed with the package, they should be tested.
This means setting up the appropriate project file for them and checking that a representative sample run correctly.
I tried to achieve this as part of #71, but there are a number of problems:
Actually setting up correctly the examples to run against the code in the PR is quite fiddly
It requires bootstrapping the examples' Project.toml and then adding the current version of JetReconstruction as the development version of the package
As, in the CI, the checkout is for JetReconstruction.jl this means making a softlink from JetReconstruction to here so that Pkg.develop(path=...) works
However, although mechanically this is almost doing the correct thing, in the CI there are some issues:
The dependencies are heavy and some for GLMakie actually seem to timeout
As these are CI machines, they can't correctly setup GLMakie
And in addition for the nightly build there seems to be a weird issue with setting up the environment that does not happen in 1.9 and 1.10:
ERROR: LoadError: ArgumentError: Package Pkg does not have Random in its dependencies:
- Note that the following manifests in the load path were resolved with a potentially
different DEV version of the current version, which may be the cause of the error.
Try to re-resolve them in the current version, or consider deleting them if that fails:
/tmp/jl_qr3gn6/Manifest.toml
- You may have a partially installed environment. Try `Pkg.instantiate()`
to ensure all packages in the environment are installed.
- Or, if you have Pkg checked out for development and have
added Random as a dependency but haven't updated your primary
environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with Pkg
I currently have no insight into that one.
What needs to be done here is:
Restructure the examples so that the CLI ones can be run in a lighter weight environment, not depending on GLMakie
Figure out the problem for the current nightly project setup
The text was updated successfully, but these errors were encountered:
As the examples are distributed with the package, they should be tested.
This means setting up the appropriate project file for them and checking that a representative sample run correctly.
I tried to achieve this as part of #71, but there are a number of problems:
Project.toml
and then adding the current version ofJetReconstruction
as the development version of the packageJetReconstruction.jl
this means making a softlink fromJetReconstruction
to here so thatPkg.develop(path=...)
worksHowever, although mechanically this is almost doing the correct thing, in the CI there are some issues:
And in addition for the nightly build there seems to be a weird issue with setting up the environment that does not happen in 1.9 and 1.10:
I currently have no insight into that one.
What needs to be done here is:
The text was updated successfully, but these errors were encountered: