Generic strategy switching #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better use of the strategy enum (with conversion to/from strings as needed) Introduce the generic_jet_reconstruction wrapper that supports also the "Best" strategy, which dynamically switches algorithm based on the event cluster density.
EnumX provides a scoped enum, which is much nicer when the enum names are quite generic (like "Best") This doesn't work with MLStyle, so drop the switching back to a simple "if .. elseif ..." construct
Use the explicit name "Strategy" for the emun type instead of the generic "T" (this works better with the --help option)
Results indicated that N2Tiled gets faster than N2Plain between 65 and 112 initial clusters, so 90 is a good intermediate pick
Update to new strategy enum
|
Self merging for further development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the use of Emums that provide the different strategy switches. We use
EnumXto have these scoped, otherwise generic names likeBestwould be troublesome. CLI string values are automatically mapped to the different strategy names.A
Beststrategy is implemented that switches betweenN2TiledandN2Plainbased on empirical measurements.The demonstration code is simplified by always calling the
generic_jet_reconstructfunction, delegating the strategy decision to inside the package (where it should be!).Closes #28.
Closes #27.