tag 1.0 with ProtoBuf pinned to working version #39
+31
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPCClient.jl requires ProtoBuf v0.11. It is incompatible with 1.x versions of ProtoBuf as it was a significant rewrite and protobuf services are not yet supported there. This PR is to pin ProtoBuf version requirement to v0.11 and tag a new release of gRPCClient.
tanmaykm
force-pushed
the
tan/misc
branch
2 times, most recently
from
504389a to
44c839c
Compare
|
Not sure why codegen is failing in CI. Things seem to work fine locally. Trying to dig into it |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 91.90% 91.84% -0.06%
==========================================
Files 5 5
Lines 321 331 +10
==========================================
+ Hits 295 304 +9
- Misses 26 27 +1 ☔ View full report in Codecov by Sentry. |
also guard against CI environment setting the COVERAGE env variable, which can conflict with the protobuf plugin script
also add experimental flag indicator to CI job name for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPCClient.jl requires ProtoBuf v0.11. It is incompatible with 1.x versions of ProtoBuf as it was a significant rewrite and protobuf services are not yet supported there. This PR is to pin ProtoBuf version requirement to v0.11 and tag a new release of gRPCClient.