From 2d447986b6377a6724ae59380f087c2b270e7795 Mon Sep 17 00:00:00 2001 From: Tanmay Mohapatra Date: Fri, 26 Jul 2024 12:54:14 +0530 Subject: [PATCH] chore: add delay for docker tools, doc updates (#80) Added slight delay in tools for docker commands to avoid a harmless but unnecessary error message. Corrected codecov badge in README. Stated a new file CONTRIBUTING.md with development specific notes. --- CONTRIBUTING.md | 16 ++++++++++++++++ README.md | 2 +- src/tools.jl | 1 + 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..804fb7a --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,16 @@ +# Guidelines For Contributing + +### Updating the code generator + +The ["openapi-generator"](https://github.com/OpenAPITools/openapi-generator/) repository contains the code generator for Julia. For any changes that also need updates to the generated code, a PR needs to be made to the `openapi-generator` repo. Relevant files: +- +- +- +- +- +- +- +- +- +- + diff --git a/README.md b/README.md index 2c8cf23..267b674 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # OpenAPI [![Build Status](https://github.com/JuliaComputing/OpenAPI.jl/workflows/CI/badge.svg)](https://github.com/JuliaComputing/OpenAPI.jl/actions?query=workflow%3ACI+branch%3Amain) -[![codecov.io](http://codecov.io/github/JuliaComputing/OpenAPI.jl/coverage.svg?branch=main)](http://codecov.io/github/JuliaComputing/OpenAPI.jl?branch=main) +[![codecov](https://codecov.io/gh/JuliaComputing/OpenAPI.jl/branch/main/graph/badge.svg?token=iZeFL7Js0l)](https://codecov.io/gh/JuliaComputing/OpenAPI.jl) This is the Julia library needed along with code generated by the [OpenAPI generator](https://openapi-generator.tech/) to help define, produce and consume OpenAPI interfaces. diff --git a/src/tools.jl b/src/tools.jl index 03a32ef..f234dde 100644 --- a/src/tools.jl +++ b/src/tools.jl @@ -45,6 +45,7 @@ function _stop_docker(image_name::AbstractString, image_type::AbstractString; us return false end + sleep(5) container_id = strip(String(read(find_cmd))) if !isempty(container_id) rm_cmd = `$docker rm $container_id`