Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default timeout too large? #105

Open
antoine-levitt opened this issue Apr 24, 2018 · 3 comments
Open

Default timeout too large? #105

antoine-levitt opened this issue Apr 24, 2018 · 3 comments

Comments

@antoine-levitt
Copy link

The current default timeout of five seconds is annoyingly large for simple benchmarking (if I want to benchmark four different versions of a simple loop, I have to wait 20s). How about reducing it to 1s? The rationale is that 1s is largely sufficient for a simple microkernel benchmark, and longer tests should probably not do a default @btime anyway.

@gdalle gdalle added this to the v2.0 milestone Sep 18, 2023
@gdalle
Copy link
Collaborator

gdalle commented Sep 18, 2023

@antoine-levitt how breaking do you think this change would be?

@antoine-levitt
Copy link
Author

This is a user-facing tool more than a library so I would imagine the notion of breaking is weaker here, but I guess in the end it depends on how strictly you believe in semver

@gdalle gdalle removed this from the v2.0 milestone Jan 5, 2024
@willow-ahrens
Copy link
Collaborator

I think it would be fine to lower this to two seconds. I have a benchmark suite for Finch that we can test on and see how we feel regarding the change in variance. We may want to add actual hypothesis testing as in ##74 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants