Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backwards compatibility package extension logic #347

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

mtfishman
Copy link
Contributor

Some weakdeps were listed as deps so that package extensions could be loaded in older Julia versions, which doesn't seem necessary now since LazyArrays.jl requires Julia 1.10. See also JuliaArrays/BlockArrays.jl#431.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (eeea5ff) to head (58fedb5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          17       17           
  Lines        3155     3155           
=======================================
  Hits         3018     3018           
  Misses        137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

Thanks. Just curious is there any negative impact on including them as both dependencies and weak dependencies?

@dlfivefifty dlfivefifty merged commit 3bfdefb into JuliaArrays:master Nov 13, 2024
16 checks passed
@mtfishman mtfishman deleted the patch-1 branch November 13, 2024 14:29
@mtfishman
Copy link
Contributor Author

mtfishman commented Nov 13, 2024

Thanks. Just curious is there any negative impact on including them as both dependencies and weak dependencies?

I think in principle it shouldn't, though my guess is that it will fix the test failure related to LazyArraysBlockArraysExt discussed in JuliaArrays/BlockArrays.jl#431. I think maybe for now it just confuses the package system about what dependencies are expected to be loaded, though that is probably a bug and the package system should be smart enough to deal with it. (Also, I like to look at the Project.toml of packages to see what kind of dependencies it has, so listing things as dependencies which are really just weak dependencies may confuse people.)

@mtfishman
Copy link
Contributor Author

mtfishman commented Nov 13, 2024

As a more obvious downside of listing them as both dependencies and weak dependencies, didn't that cause those packages (BandedMatrices, BlockArrays, BlockBandedMatrices, StaticArrays) to be downloaded and installed for every user, even if they didn't need them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants