Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy rank one matrix #178

Open
blegat opened this issue Jun 26, 2021 · 1 comment
Open

Lazy rank one matrix #178

blegat opened this issue Jun 26, 2021 · 1 comment

Comments

@blegat
Copy link

blegat commented Jun 26, 2021

Trying to build a lazy rank one matrix, I get an error

julia> x = ones(2)
2-element Vector{Float64}:
 1.0
 1.0

julia> a = @~ x * x'
Applied(*,[1.0, 1.0],[1.0 1.0])

julia> materialize(a)
ERROR: AssertionError: length(x) == 1
Stacktrace:
  [1] similar
    @ ~/.julia/packages/ArrayLayouts/pPGEV/src/muladd.jl:412 [inlined]
  [2] similar
    @ ~/.julia/packages/ArrayLayouts/pPGEV/src/muladd.jl:42 [inlined]
  [3] similar
    @ ~/.julia/packages/ArrayLayouts/pPGEV/src/muladd.jl:43 [inlined]
  [4] copy(M::ArrayLayouts.MulAdd{ArrayLayouts.DenseColumnMajor, ArrayLayouts.DualLayout{ArrayLayouts.DenseRowMajor}, ArrayLayouts.ZerosLayout, Float64, Vector{Float64}, Adjoint{Float64, Vector{Float64}}, FillArrays.Zeros{Float64, 2, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}}}})
    @ ArrayLayouts ~/.julia/packages/ArrayLayouts/pPGEV/src/muladd.jl:70
  [5] copy(M::Mul{ArrayLayouts.DenseColumnMajor, ArrayLayouts.DualLayout{ArrayLayouts.DenseRowMajor}, Vector{Float64}, Adjoint{Float64, Vector{Float64}}})
    @ ArrayLayouts ~/.julia/packages/ArrayLayouts/pPGEV/src/mul.jl:108
  [6] materialize(M::Mul{ArrayLayouts.DenseColumnMajor, ArrayLayouts.DualLayout{ArrayLayouts.DenseRowMajor}, Vector{Float64}, Adjoint{Float64, Vector{Float64}}})
    @ ArrayLayouts ~/.julia/packages/ArrayLayouts/pPGEV/src/mul.jl:105
  [7] mul
    @ ~/.julia/packages/ArrayLayouts/pPGEV/src/mul.jl:106 [inlined]
  [8] copy(M::Applied{LazyArrays.MulStyle, typeof(*), Tuple{Vector{Float64}, Adjoint{Float64, Vector{Float64}}}})
    @ LazyArrays ~/.julia/packages/LazyArrays/pdsik/src/linalg/mul.jl:13
  [9] materialize(A::Applied{LazyArrays.MulStyle, typeof(*), Tuple{Vector{Float64}, Adjoint{Float64, Vector{Float64}}}})
    @ LazyArrays ~/.julia/packages/LazyArrays/pdsik/src/lazyapplying.jl:81

This however works:

julia> a = @~ x .* x'
Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{2}}(*, ([1.0, 1.0], [1.0 1.0]))

julia> materialize(a)
2×2 Matrix{Float64}:
 1.0  1.0
 1.0  1.0
@dlfivefifty
Copy link
Member

I normally just do ApplyArray(*, x’, x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants