Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically convert Date in ContinuousEncoder #535

Open
ParadaCarleton opened this issue Oct 15, 2023 · 2 comments
Open

Automatically convert Date in ContinuousEncoder #535

ParadaCarleton opened this issue Oct 15, 2023 · 2 comments
Labels
breaking enhancement New feature or request

Comments

@ParadaCarleton
Copy link

Right now, inputting a date into a ContinuousEncoder just drops it, but it seems more reasonable to handle by converting dates into a number of days.

[ Info: Some features cannot be replaced with `Continuous` features and will be dropped: [:Year]. 
@ablaom
Copy link
Member

ablaom commented Oct 17, 2023

In principle this sounds like a good idea. However, we do have UnivariateTimeTypeToContinuous and I would prefer to avoid code duplication.

Perhaps we could add date_time_encoder=UnivariateTimeTypeToContinous() as a new ContinuousEncoder hyperparameter, and use that to treat columns with scitype ScientificTimeType (corresponding to any machine type <: Dates.TimeType).

What do you think?

@ablaom ablaom added the enhancement New feature or request label Oct 17, 2023
@ParadaCarleton
Copy link
Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
Status: priority low / straightforward
Development

No branches or pull requests

2 participants