Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose rng hyperparameter in DecsionTreeRegressor/Classifier #223

Closed
ablaom opened this issue Apr 8, 2020 · 2 comments
Closed

Expose rng hyperparameter in DecsionTreeRegressor/Classifier #223

ablaom opened this issue Apr 8, 2020 · 2 comments
Labels
easy good first issue Good for newcomers

Comments

@ablaom
Copy link
Member

ablaom commented Apr 8, 2020 •
edited
Loading

The DecisionTree.jl models now have rng as a hyperparameter, which MLJModels should expose.

default value: nothing (meaning use GLOBAL_RNG)
type: Union{Int,AbstractRNG}

If set to integer, then fit method should pass rng_internal = MersenneTwister(rng) to DecisionTree package.
@ablaom ablaom added easy good first issue Good for newcomers labels Apr 8, 2020
@ablaom
Copy link
Member Author

ablaom commented Apr 9, 2020

Optionally combine with #177

@ablaom
Copy link
Member Author

ablaom commented Feb 4, 2024

This appears to have been sorted.

@ablaom ablaom closed this as completed Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy good first issue Good for newcomers
Projects
General
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom