-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export scitype
method.
#131
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to a recent change in
ScientificTypesBase,jl
from version 2.0 to 3.0, theScientifictypesBase.scitype
method is now a two argument method. Packages depending onMLJModelInterface.jl
previously depended on the previous one argument version defined in version 2.0 series ofScientifictypesBase
package.A workaround is needed to avoid making
MLJModelInterface
breaking for its's users. This involvesscitype
method in MLJModelInterface. Something in the lines ofThe corresponding
FullInterface
method would be implemented atMLJBase/src/Interface/data_utils.jl
.scitype
method atMLJModelInterface
(Needed as users expect that thescitype
method is exported. see MLJModelInterface no longer exportingscitype
#129 )But implementing the second step also leads to method import clashes with
ScientificTypes.scitype
at MLJBase. For now a hack at MLJBase/src/MLJBase.jl fixes this issue, but going forward thescitype
method shouldn't be exported. Hence users that want to use thescitype
method would have to qualify it with the package name e.g.MLJModelinterface.scitype(X)
.The text was updated successfully, but these errors were encountered: