Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export UnivariateFinite. #124

Open
ablaom opened this issue Nov 24, 2021 · 1 comment
Open

Don't export UnivariateFinite. #124

ablaom opened this issue Nov 24, 2021 · 1 comment

Comments

@ablaom
Copy link
Member

ablaom commented Nov 24, 2021

The fact that this is exported is necessitating a hack in MLJBase/src/MLJBase.jl to enable UnivariateFinite code to be replaced with CategoricalDistributions.jl as a dependency.

And remove the doc-string as a duplication of one now provided at CategoricalDistributions?

@OkonSamuel
Copy link
Member

@ablaom I won't suggest removing the doc-string though, since developers relying on the lightweight MLJModelInterface may not also want to depend on the heavier MLJBase/CategoricalDistributions. They may still want to query the docstring for UnivariateFinite object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants