Skip to content

Latest commit

 

History

History
108 lines (55 loc) · 1.8 KB

PYLINT.md

File metadata and controls

108 lines (55 loc) · 1.8 KB

pylint changes

We used pylint on the freshly created GUI_main.py.

Run before fixing

first pylint output

First Fixes

The problems are numbered (orange integers) in the screenshot above.

1 trailing newlines

Old code: Empty lines at the end of the file
1 old

Fixed code: removed empty lines, lkast line is now last line of code

1 new

2 missing module docstring

Old code: line 1 is not a module description

2 old

Fixed code: line 1 is now a desciption of the module

2 new

3 module name "GUI_main.py" doesn't conform to snake_case naming confention

We renamend GUI_main.py to gui.py

4 missing function or method doscstring

Old code:

4 old

Fixed code:

4 new

5 missing function or method doscstring

Old code:

5 old

Fixed code:

5 new

6 missing function or method doscstring

Old code:

6 old

Fixed code:

6 new

7 unnecessary-lambda-assignment

Old code:

7 old

Fixed code:

7 new

8 Wrong import order

Old code:

8 old

Fixed code:

8 new

9 Wrong import order

We can discared this change, because we noticed we don't need the os library.

Second fixes

We reruned pylint and this was the reslust:

second plyint output

1 Final new line missing

Old code:

2.1 old

Fixed code:

2.1 new code

Third fixes

third pylint output