-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: post release permissions error #1750
Conversation
permissions: { | ||
issues: "write", | ||
"pull-requests": "write", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😁 I do think it kind of painfully funny that in attempting to remove one annoying end-to-end test (script/migrate-test-e2e.test.ts
) I'm temporarily giving you another probably annoying extra bit of work... thanks for tolerating it and also contributing to the new block engine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"painfully funny" is accurate!
I've come to regard the automated tests of CTA as developer hostile end-of-level baddies. If I was into darts I'd print out one of the failed test runs and pin it to the board 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 perfection. Also a relief to finally have the GHA permissions issues figured out & fixed. Thanks so much @johnnyreilly!
🎉 This is included in version v1.77.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
This PR applies the change suggested by @apexskier here to attempt to fix post-release permissions:
apexskier/github-release-commenter#545 (comment)