Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post release permissions error #1750

Merged
merged 6 commits into from
Dec 7, 2024
Merged

Conversation

johnnyreilly
Copy link
Collaborator

PR Checklist

Overview

This PR applies the change suggested by @apexskier here to attempt to fix post-release permissions:

apexskier/github-release-commenter#545 (comment)

permissions: {
issues: "write",
"pull-requests": "write",
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 I do think it kind of painfully funny that in attempting to remove one annoying end-to-end test (script/migrate-test-e2e.test.ts) I'm temporarily giving you another probably annoying extra bit of work... thanks for tolerating it and also contributing to the new block engine!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"painfully funny" is accurate!

I've come to regard the automated tests of CTA as developer hostile end-of-level baddies. If I was into darts I'd print out one of the failed test runs and pin it to the board 😅

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 perfection. Also a relief to finally have the GHA permissions issues figured out & fixed. Thanks so much @johnnyreilly!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 85c53e7 into main Dec 7, 2024
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the post-release-permissions branch December 7, 2024 22:06
Copy link

🎉 This is included in version v1.77.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Post release action doesn't work after initial release
2 participants