Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Use root-level slashes for root-level directories in .gitignore and .prettierignore #1693

Closed
3 tasks done
JoshuaKGoldberg opened this issue Nov 25, 2024 · 1 comment · Fixed by #1696
Closed
3 tasks done

🐛 Bug: Use root-level slashes for root-level directories in .gitignore and .prettierignore #1693

JoshuaKGoldberg opened this issue Nov 25, 2024 · 1 comment · Fixed by #1696
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

For .gitignore and .prettierignore (which uses .gitignore syntax per https://prettier.io/docs/en/ignore.html#ignoring-files-prettierignore), some root-level directories should be ignored: e.g. lib/. Nested directories that happen to match the name should not be ignored: e.g. src/lib/.

Actual

Right now, the files just include lines like lib/. Those match lib/, src/lib/, src/other-nested-dir/lib/, etc.

Additional Info

Splitting out of #1670.

Note that node_modules/ should be kept to matching all directories.

💖
@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Something isn't working :( label Nov 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Nov 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Nov 25, 2024
This was referenced Nov 25, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.77.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use root-level slashes in .gitignore and .prettierignore JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg