From 09859ecae8d30681cba64c05282848788c70b737 Mon Sep 17 00:00:00 2001
From: Josh Keegan <josh.keegan@gmx.com>
Date: Wed, 15 Nov 2023 18:50:42 +0000
Subject: [PATCH] bump: .net 8

---
 .github/workflows/cicd.yaml                                | 2 +-
 .../UnitTests.SingleThreaded.csproj                        | 2 +-
 test/UnitTests/Exceptions/SkipTestExceptionTests.cs        | 4 ++--
 test/UnitTests/UnitTests.csproj                            | 7 ++++++-
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/cicd.yaml b/.github/workflows/cicd.yaml
index a1f6bf2..a3e87ff 100644
--- a/.github/workflows/cicd.yaml
+++ b/.github/workflows/cicd.yaml
@@ -8,7 +8,7 @@ jobs:
   ci_build:
     name: CI Build
     runs-on: ubuntu-latest
-    container: joshkeegan/dotnet-mixed-build:6.1
+    container: joshkeegan/dotnet-mixed-build:7.0
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/test/UnitTests.SingleThreaded/UnitTests.SingleThreaded.csproj b/test/UnitTests.SingleThreaded/UnitTests.SingleThreaded.csproj
index 34ad8f8..db3aa99 100644
--- a/test/UnitTests.SingleThreaded/UnitTests.SingleThreaded.csproj
+++ b/test/UnitTests.SingleThreaded/UnitTests.SingleThreaded.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net48</TargetFrameworks>
+    <TargetFrameworks>net8.0;net48</TargetFrameworks>
 
     <IsPackable>false</IsPackable>
   </PropertyGroup>
diff --git a/test/UnitTests/Exceptions/SkipTestExceptionTests.cs b/test/UnitTests/Exceptions/SkipTestExceptionTests.cs
index c7d4f91..54f2f8c 100644
--- a/test/UnitTests/Exceptions/SkipTestExceptionTests.cs
+++ b/test/UnitTests/Exceptions/SkipTestExceptionTests.cs
@@ -18,11 +18,11 @@ public void Serialisation_RoundTrip_RetainsData()
 
             // Act
             SkipTestException actual;
+#pragma warning disable SYSLIB0011 // Type or member is obsolete
+#pragma warning disable 618
             BinaryFormatter formatter = new BinaryFormatter();
             using (MemoryStream s = new MemoryStream())
             {
-#pragma warning disable SYSLIB0011 // Type or member is obsolete
-#pragma warning disable 618
                 formatter.Serialize(s, expected);
                 s.Position = 0;
                 actual = (SkipTestException) formatter.Deserialize(s);
diff --git a/test/UnitTests/UnitTests.csproj b/test/UnitTests/UnitTests.csproj
index aabf4f1..ac607cc 100644
--- a/test/UnitTests/UnitTests.csproj
+++ b/test/UnitTests/UnitTests.csproj
@@ -1,10 +1,15 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net48</TargetFrameworks>
+    <TargetFrameworks>net8.0;net48</TargetFrameworks>
 
     <IsTestProject>true</IsTestProject>
     <IsPackable>false</IsPackable>
+      
+    <!-- Required to enable BinaryFormatter so we can test [Serializable] exceptions. 
+         I don't know if anyone uses them, but it would be a breaking change to stop exceptions being serialisable, 
+         and the BinaryFormatter is only required in this test project. -->  
+    <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
   </PropertyGroup>
 
   <ItemGroup>