Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron-phonon extension #294
base: develop
Are you sure you want to change the base?
Electron-phonon extension #294
Changes from 19 commits
f7310b8
4ffbe56
fa6f13b
caf7a34
e7507f7
bf49a31
2ef4fb8
f0a10a6
582a24e
f9d70d5
69e1ef5
7925ba9
ccc2649
ce14a30
d839b23
00870e5
e2e703b
dab3687
ad5c2cd
e782941
096ea3f
b425c44
3a578a2
f79e95a
4ea65a6
7eec46b
c01760f
e59ead6
a3c3675
317dcf3
ee14708
eeeb44c
58ed7af
93e6a49
3edb5e8
4c72ba7
d66d467
20d86a2
24a99d5
dfb3a4d
a0cfab5
cf8f379
28d40df
298ad97
51b48a1
6fb14af
5a0a70a
9dfd155
c355ffa
40c5ed5
3b1256f
27b5365
a801b80
42faa91
5d7c560
ee78aad
92e3620
1a86cb4
9bcb208
0ebe6f2
705d1e6
44bea2d
4963d63
e02282c
44505b5
fab267b
03f7b05
40e9128
b73fdd7
cc4d29d
fb69584
530c5ff
42cdff4
d9582f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you settings this and not just recomputing it as a check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this is a good unit test.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying I should load beta_shift and el_trial instead of computing them in the run script (and have a unites for
variational_trial_toyozawa
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, computing them in the script is fine. I was saying the trial wavefunction should recompute the energy given your optimized orbitals / parameters. This is a useful sanity check when running jobs as we typically generate trials externally so it's a form of handshake to make sure everything is formatted / interpreted correctly. Here you're just setting them rather than recalculating them via the trial.
The unit test is separate and is just a simple assertion that building a trial wavefunction from your optimized parameters reproduces the variational energy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete lines 15-17. we meant this to be an instruction for contributing to addons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete