Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position issue of fullscreen preview #101

Open
JonathanTreffler opened this issue Feb 15, 2021 · 1 comment · May be fixed by #96
Open

Fix position issue of fullscreen preview #101

JonathanTreffler opened this issue Feb 15, 2021 · 1 comment · May be fixed by #96
Assignees

Comments

@JonathanTreffler
Copy link
Owner

Currently, if any parent of the gallery uses transform: translate(...) the position of the fullscreen preview gets messed up, due to an css limitation with position: fixed.

@JonathanTreffler JonathanTreffler self-assigned this Feb 15, 2021
@JonathanTreffler
Copy link
Owner Author

I will fix this issue by using vue-simple-portal. It moves the fullscreen image into the body directly, while still preserving the vue reactivity.

@JonathanTreffler JonathanTreffler linked a pull request Feb 15, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant