New argument to estimateD to warn about duplicates and optionally remove without error
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onally avoid weird behaviors. had some issues updating documentation: > devtools::document() ℹ Updating iNEXT documentation ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Changes in roxygen2 7.0.0: * `%` is now escaped automatically in Markdown mode. Please carefully check .Rd files for changes ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Setting `RoxygenNote` to "7.2.0" ℹ Loading iNEXT Writing ChaoShannon.Rd Writing ChaoSimpson.Rd Writing ggiNEXT.Rd Writing iNEXT.Rd Writing estimateD.Rd Writing plot.iNEXT.Rd Warning messages: 1: roxygen2 requires Encoding: "UTF-8" ℹ Current encoding is NA 2: Skipping NAMESPACE ✖ It already exists and was not generated by roxygen2.
|
ref to #68 |
|
Closing this PR as it looks like the duplicate removal was deemed unnecessary, merging #68 solved my issue and way more simply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (like another PR from KaiHsiangHu) was an attempt to resolve #67. I added a warning about duplicates and an
removeDupsargument to estimateD that I think, when TRUE, removes duplicates without throwing an error due to name mismatches. The documentation didn't exactly update for me withdevtools::document(), and this PR wasn't passing R CMD check on my machine, but I think that will be very quick for the maintainers.