Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-873 Issue with MarianTransformers models #13908

Conversation

danilojsl
Copy link
Contributor

Description

The change solves an issue with Marian transformers in Python by handling vocabulary type from Python side

Motivation and Context

Solves Marian transformers error in Python

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added bug-fix DON'T MERGE Do not merge this PR labels Jul 30, 2023
@maziyarpanahi maziyarpanahi linked an issue Jul 30, 2023 that may be closed by this pull request
1 task
@maziyarpanahi maziyarpanahi self-assigned this Jul 30, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/502-release-candidate August 2, 2023 13:18
@maziyarpanahi maziyarpanahi merged commit 6fae7b8 into release/502-release-candidate Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix DON'T MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Py4JJavaError: An error occurred while calling o2951.fullAnnotateJava.
2 participants