Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared - Implement effects #256

Open
3 tasks
Joery-M opened this issue Oct 11, 2024 · 0 comments
Open
3 tasks

Shared - Implement effects #256

Joery-M opened this issue Oct 11, 2024 · 0 comments
Assignees
Labels
implement Implement functionality that is expected to work Shared Will affect packages/shared

Comments

@Joery-M
Copy link
Owner

Joery-M commented Oct 11, 2024

Effects definition

This issue explains what 'effects' represent in the application.

Effects are modules that are added to timeline items (#257) to alter rendering and behavior of said items.

Effects can be grouped into the following groups:

  • Transform
  • Generate
  • Transition
  • Modify
  • Audio
  • Source

This list is subject to change with new features and should only be maintained as a baseline.

Effect types

Transform

This effect type transforms the existing image. For example moving the image to the right by 10 pixels.

Generate

This effect type generates an overlay on top of the existing image. For example:

  • Text
  • Outlines
  • Fake lens flares

Transition

This effect type manages a transition between 2 timeline items. It should be visible on the timeline.
Examples:

  • Cross-fade (audio and video)
  • Slide
  • Wipe

Modify

Name needs to change, this is very broad.

This effect type modifies the existing image or audio. So basically everything that doesn't fall into other categories.

Audio

This effect type specifically applies to audio, for example:

  • Volume
  • Normalize
  • Panning
  • Reverb

Source

This effect type generates the source data that will be used on the timeline item. There can only be 1 video source for each timeline item.
For video, the effect defines the base width and height and will provide the base image that will be used.
Examples:

  • Media files
  • SVG
  • Static color
  • External timeline
  • Audio tone
  • MIDI
  • Subtitle file (VTT, SRT)
    For video, if there is no source to define width and height, the width and height of the current timeline should be used.

The source effect should also pass the following information to the timeline item:

  • Source name
  • Source type to be used for timeline colors
  • Source duration
  • (Video) Frame width and height

Here is what this issue should implement:

  • Source for static files (images)
  • Source for chunked files (video, audio)
  • Image transformation
@Joery-M Joery-M added implement Implement functionality that is expected to work Safelight UI Will affect Safelight UI Shared Will affect packages/shared labels Oct 11, 2024
@Joery-M Joery-M added this to the Setup and structure milestone Oct 11, 2024
@Joery-M Joery-M changed the title SL UI/Shared - Implement effects Shared - Implement effects Oct 14, 2024
@Joery-M Joery-M removed the Safelight UI Will affect Safelight UI label Oct 14, 2024
@Joery-M Joery-M self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implement Implement functionality that is expected to work Shared Will affect packages/shared
Projects
None yet
Development

No branches or pull requests

1 participant