Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SL UI - Make panels generic and configurable #16

Open
2 of 6 tasks
Joery-M opened this issue Apr 21, 2024 · 4 comments
Open
2 of 6 tasks

SL UI - Make panels generic and configurable #16

Joery-M opened this issue Apr 21, 2024 · 4 comments
Assignees
@Joery-M
Labels
enhancement New feature or request implement Implement functionality that is expected to work Safelight UI Will affect Safelight UI

Comments

@Joery-M
Copy link
Owner

Joery-M commented Apr 21, 2024 •
edited
Loading

Requirements:

  • Panels can be moved and new slots can be created (might be a later ticket)
  • Panels should be able to define title, icon and default location
  • Panels can be closed
  • Panels can be opened from menu bar (menu bar in SL UI - Project state management #14)
  • Panels can be registered dynamically
  • Panel locations can be stored in localStorage
@Joery-M Joery-M added enhancement New feature or request implement Implement functionality that is expected to work Safelight UI Will affect Safelight UI labels Apr 21, 2024
@Joery-M Joery-M self-assigned this Apr 29, 2024
@Joery-M Joery-M mentioned this issue Apr 29, 2024
Closed
5 tasks
@Joery-M
Copy link
Owner Author

Joery-M commented Apr 30, 2024

Having a look at https://acreom.com/blog/modular-tab-system

@Joery-M
Copy link
Owner Author

Joery-M commented May 5, 2024

Point 1 has been turned into #27

@Joery-M
Copy link
Owner Author

Joery-M commented May 5, 2024

Point 4 has been changed into a plus button at the end of the tab menu, which opens an overlay where you can select a tab to add.
This also invalidates the default position requirement of point 2.

@Joery-M Joery-M linked a pull request May 5, 2024 that will close this issue
16 sl UI make panels generic and configurable #28
Merged
@Joery-M Joery-M removed a link to a pull request May 5, 2024
16 sl UI make panels generic and configurable #28
Merged
@Joery-M
Copy link
Owner Author

Joery-M commented May 5, 2024

Partial PR has been made to keep main up to date with the changes made in this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joery-M Joery-M

Labels
enhancement New feature or request implement Implement functionality that is expected to work Safelight UI Will affect Safelight UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Joery-M