Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core patch module doesn't work? #3

Closed
1 task done
SyedTahseen opened this issue Aug 17, 2024 · 10 comments
Closed
1 task done

Core patch module doesn't work? #3

SyedTahseen opened this issue Aug 17, 2024 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@SyedTahseen
Copy link

Steps to reproduce/复现步骤

n/a

Expected behaviour/预期行为

why core patch module doesn't work? while it is working perfectly in original lsposed

Actual behaviour/实际行为

n/a

Xposed Module List/Xposed 模块列表

core patch

Magisk Module List/Magisk 模块列表

n/a

LSPosed version/LSPosed 版本

v1.10.0 (7068)

Android version/Android 版本

13

Magisk version/Magisk 版本

apatch latest

Riru version/Riru 版本

N/A

Version requirement/版本要求

  • I am using latest debug CI version of LSPosed and enable verbose log/我正在使用最新 CI 调试版本且启用详细日志

Logs/日志

n/a

@SyedTahseen SyedTahseen added the bug Something isn't working label Aug 17, 2024
@JingMatrix
Copy link
Owner

Please provide relevant logs, if there is no abnormal logs, then this should be an issue of LSPosed/CorePatch and you should report to them.

@SyedTahseen
Copy link
Author

i asked in core patch community, they said it is working perfectly in lsposed and every known lsposed fork version so blame you for not working in your lsposed version.
and I couldn't find logs in lsposed, or maybe i missed it because it is too long list of logs

@JingMatrix
Copy link
Owner

Did you try the original LSPosed ? Could you please confirm that CorePatch works well with it ?
I am already on Android 15, couldn't repeat the above check by my own.

@SyedTahseen
Copy link
Author

I was using original lsposed before installing this one, and original was working perfectly without any problem. I just installed this fork because you are continuously maintaining this fork that's why.
and recently i changed lsposed to original and it is working fine with core patch

@JingMatrix
Copy link
Owner

CorePatch doesn't support Android 15, for which I cannot test on my device.
Please upload your logs to help figuring out the problems.

@JingMatrix
Copy link
Owner

I forked CorePatch and made it available for Android 15: LSPosed/CorePatch#115 .
After testing on my devices, everything works well.
You may try my fork to see if problems still exist: https://github.com/JingMatrix/CorePatch/actions/runs/10444352168

@JingMatrix JingMatrix added invalid This doesn't seem right and removed bug Something isn't working labels Aug 18, 2024
@acidcitrus
Copy link

In OxygenOS 14.0.0.840 for the OnePlus 12, it seems changes from Android 15 have been backported to 14, so the use of your LSposed fork was necessary to fix this error that prevented LuckyTool module from working: LSPosed/LSPlant#97.
CorePatch also stopped working since 14.0.0.840. However, your CorePatch fork doesn't enable the fix for 15 on my rom because it is still 14, even though changes from 15 breaking CorePatch have been backported to 14. I suggest adding an option for ColorOS/OxygenOS users in CorePatch to fix support for later versions of 14.

@JingMatrix JingMatrix reopened this Aug 30, 2024
@JingMatrix JingMatrix added help wanted Extra attention is needed and removed invalid This doesn't seem right labels Aug 30, 2024
@JingMatrix
Copy link
Owner

@acidcitrus Thanks for the information.
In this case, I think it is better for you to build your own version of CorePatch.
If you are not capable of doing that (please let me know), I can add a branch to my CorePatch fork for your help since it is not hard.

@acidcitrus
Copy link

@acidcitrus Thanks for the information. In this case, I think it is better for you to build your own version of CorePatch. If you are not capable of doing that (please let me know), I can add a branch to my CorePatch fork for your help since it is not hard.

I'd be grateful if you could add a branch since I don't have experience in building.

@JingMatrix
Copy link
Owner

I'd be grateful if you could add a branch since I don't have experience in building.

Done, I accidently bothered the upstream 😳

JingMatrix pushed a commit that referenced this issue Sep 12, 2024
fix: build not passing
privacyguy123 added a commit to privacyguy123/LSPosed that referenced this issue Sep 25, 2024
privacyguy123 added a commit to privacyguy123/LSPosed that referenced this issue Sep 25, 2024
privacyguy123 added a commit to privacyguy123/LSPosed that referenced this issue Sep 25, 2024
privacyguy123 added a commit to privacyguy123/LSPosed that referenced this issue Sep 25, 2024
Template JingMatrix#2

Template JingMatrix#3

Template JingMatrix#4
privacyguy123 added a commit to privacyguy123/LSPosed that referenced this issue Sep 25, 2024
privacyguy123 added a commit to privacyguy123/LSPosed that referenced this issue Sep 25, 2024
Template

Template JingMatrix#2

Template JingMatrix#3

Template JingMatrix#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants