Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a fair comparison with others if you use gt focal length in your evaluation? #30

Open
gdwei opened this issue Mar 8, 2019 · 3 comments

Comments

@gdwei
Copy link

gdwei commented Mar 8, 2019

Hi, I wonder if it is a fair comparison with others if you use groundtruth focal length in your evaluation. This means you've known human size in test time and you do not consider the error introduced by the ambiguity of size ? Thanks.

@John6333
Copy link

John6333 commented Apr 8, 2019

Agree with @gdwei. As far as I know, no other published 3D pose estimation methods before this work use the GT camera parameters or GT root depth, while this one used both.

@victor-gz
Copy link

Hi @gdwei, @John6333, where did you see they use the ground truth focal length? Could you point me to where it is in the code?

@John6333
Copy link

Hi @VGonzalez88, please check this function, especially line623~637.

def evaluate(self, preds, save_path):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants