Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use latest version of PyBASIC #1

Open
JiFish opened this issue Apr 10, 2021 · 4 comments
Open

Refactor to use latest version of PyBASIC #1

JiFish opened this issue Apr 10, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@JiFish
Copy link
Owner

JiFish commented Apr 10, 2021

Pull input changes from PyBasic richpl/PyBasic#19

@JiFish JiFish added the enhancement New feature or request label Apr 10, 2021
@brickbots
Copy link

Hi Hi! If/When my PR to PyBasic for the modularization and I/O abstraction gets merged, I'd be willing to help with the job of re-integrating PyBasic into Artemis.

As you sagely pointed out, there's still some thought to be done around the mechanism for extending PyBasic with new functions/keywords, but maybe it can all come together and make it easier to integrate upstream changes into the Artemis project.

@JiFish
Copy link
Owner Author

JiFish commented Nov 10, 2021

Apologies for the radio silence @brickbots. I can't believe it been two months since I put this on my TODO list.

I do plan to pull in all the new changes, which will require a small refactor my end. I am eager to find time to do this around my Christmas holidays. I'm especially excited about vintage compatibility and getting rid of the need to fork.

I'll be sure to pick your mind if you are available.

@JiFish JiFish changed the title Pull input changes from PyBasic Refactor to use latest version of PyBASIC Nov 10, 2021
@brickbots
Copy link

No apologies needed! I've gotten a bit sidetracked as well recently :-)

After clarifying some of the goals of PyBasic (simple code/readability) I've started on a fork that will give up some ease of understanding for a more extensible/re-useable approach. I've already implemented and solidified all the I/O abstraction I pitched for PyBasic and I'm starting to work on restructuring the interpreter to make adding new keywords/functions via subclassing easier without modifying any of the core files.

https://github.com/brickbots/Basic2040

It might be an easier lift to integrate this fork for Artemis, and I'd be keen to collaborate on the extensibility mechanism if you have ideas.

@JiFish
Copy link
Owner Author

JiFish commented Nov 11, 2021

Sounds good. I'll be in touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants