Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicates in case of reconnection #69

Open
epeshk opened this issue Feb 6, 2020 · 1 comment
Open

Avoid duplicates in case of reconnection #69

epeshk opened this issue Feb 6, 2020 · 1 comment

Comments

@epeshk
Copy link
Contributor

epeshk commented Feb 6, 2020

Test.RdFramework.SocketWireTest.TestDisconnect test may fail because it expects to receive 1, 2, 3, 4, 5, 6 in RdSignal on server side, but due to asynchronous acknowledgement some values may be duplicated when connection dropped before server acknowledge received values.

Maybe it is expected behavior for RdSignal, but not sure that for RdProperty too. Currently, test fails even with RdProperty (but not with RdList, so I added the similar test with RdList)
@operasfantom
Copy link
Contributor

Just for now RdProperty accepts all values (if it is not master) regardless of version. So, in case when several different values are set one after another (but not their ACK) and connection is reset, these values are re-sent and accepted by the host RdProperty again. Not sure for version control of RdList and RdMap and RdCall.

@korifey ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epeshk @operasfantom