Returned code to disable 4252 warning because of problems with Unreal…

…Link build. Made spdlog static lib for RD_STATIC build.
JetBrains · Dec 19, 2023 · 683289e · 683289e
1 parent 6c204c7
commit 683289e
Show file tree

Hide file tree

Showing 31 changed files with 129 additions and 7 deletions.
diff --git a/rd-cpp/CMakeLists.txt b/rd-cpp/CMakeLists.txt
@@ -65,6 +65,8 @@ else ()
     set(PCH_CPP_OPT "")
 endif ()
 
+option(RD_STATIC "Compile RD as static library" OFF)
+
 add_subdirectory(thirdparty)
 add_subdirectory(src)
 

diff --git a/rd-cpp/src/CMakeLists.txt b/rd-cpp/src/CMakeLists.txt
@@ -1,5 +1,3 @@
-option(RD_STATIC "Compile RD as static library" OFF)
-
 add_subdirectory(rd_core_cpp)
 add_subdirectory(rd_framework_cpp)
 add_subdirectory(rd_gen_cpp)
diff --git a/rd-cpp/src/rd_core_cpp/src/main/CMakeLists.txt b/rd-cpp/src/rd_core_cpp/src/main/CMakeLists.txt
@@ -36,6 +36,7 @@ set(RD_CORE_CPP_SOURCES
         util/gen_util.h util/overloaded.h
         #pch
         ${PCH_CPP_OPT}
+        util/export_api_helper.h
 )
 
 if (RD_STATIC)
@@ -45,10 +46,14 @@ else ()
     add_library(rd_core_cpp SHARED ${RD_CORE_CPP_SOURCES})
 endif ()
 
+set(RD_CORE_EXPORT_HEADER_CUSTOM_CONTENT "#include \"util/export_api_helper.h\"")
+
 include(GenerateExportHeader)
 generate_export_header(rd_core_cpp
         BASE_NAME rd_core
-        EXPORT_MACRO_NAME RD_CORE_API)
+        EXPORT_MACRO_NAME RD_CORE_API
+        CUSTOM_CONTENT_FROM_VARIABLE RD_CORE_EXPORT_HEADER_CUSTOM_CONTENT
+)
 
 message(STATUS "Using pch by rd_core: '${ENABLE_PCH_HEADERS}'")
 

diff --git a/rd-cpp/src/rd_core_cpp/src/main/lifetime/Lifetime.h b/rd-cpp/src/rd_core_cpp/src/main/lifetime/Lifetime.h
@@ -9,6 +9,8 @@
 
 #include <rd_core_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class Lifetime;
@@ -64,4 +66,6 @@ inline size_t hash<Lifetime>::operator()(const Lifetime& value) const noexcept
 }
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_CORE_LIFETIMEWRAPPER_H
diff --git a/rd-cpp/src/rd_core_cpp/src/main/lifetime/LifetimeDefinition.cpp b/rd-cpp/src/rd_core_cpp/src/main/lifetime/LifetimeDefinition.cpp
@@ -18,7 +18,7 @@ bool LifetimeDefinition::is_terminated() const
 	return lifetime->is_terminated();
 }
 
-void LifetimeDefinition::terminate() const
+void LifetimeDefinition::terminate()
 {
 	lifetime->terminate();
 }

diff --git a/rd-cpp/src/rd_core_cpp/src/main/lifetime/LifetimeDefinition.h b/rd-cpp/src/rd_core_cpp/src/main/lifetime/LifetimeDefinition.h
@@ -11,6 +11,8 @@
 
 #include <rd_core_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class RD_CORE_API LifetimeDefinition
@@ -44,7 +46,7 @@ class RD_CORE_API LifetimeDefinition
 
 	bool is_eternal() const;
 
-	void terminate() const;
+	void terminate();
 
 	template <typename F>
 	static auto use(F&& block) -> typename util::result_of_t<F(Lifetime)>
@@ -56,4 +58,6 @@ class RD_CORE_API LifetimeDefinition
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_CORE_LIFETIME_DEFINITION_H
diff --git a/rd-cpp/src/rd_core_cpp/src/main/lifetime/LifetimeImpl.h b/rd-cpp/src/rd_core_cpp/src/main/lifetime/LifetimeImpl.h
@@ -14,6 +14,8 @@
 
 #include <rd_core_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class RD_CORE_API LifetimeImpl final
@@ -96,4 +98,6 @@ class RD_CORE_API LifetimeImpl final
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_CORE_LIFETIME_H
diff --git a/rd-cpp/src/rd_core_cpp/src/main/lifetime/SequentialLifetimes.h b/rd-cpp/src/rd_core_cpp/src/main/lifetime/SequentialLifetimes.h
@@ -6,6 +6,8 @@
 
 #include <rd_core_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class RD_CORE_API SequentialLifetimes
@@ -39,4 +41,6 @@ class RD_CORE_API SequentialLifetimes
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_CORE_SEQUENTIAL_LIFETIMES_H
diff --git a/rd-cpp/src/rd_core_cpp/src/main/util/export_api_helper.h b/rd-cpp/src/rd_core_cpp/src/main/util/export_api_helper.h
@@ -0,0 +1,15 @@
+#ifndef EXPORT_API_HELPER_H
+#define EXPORT_API_HELPER_H
+
+#if defined(_MSC_VER)
+#define RD_PUSH_STL_EXPORTS_WARNINGS \
+	_Pragma("warning(push)") \
+	_Pragma("warning(disable:4251)")
+#define RD_POP_STL_EXPORTS_WARNINGS \
+	_Pragma("warning(pop)")
+#else
+#define RD_PUSH_STL_EXPORTS_WARNINGS
+#define RD_POP_STL_EXPORTS_WARNINGS
+#endif
+
+#endif //EXPORT_API_HELPER_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/CMakeLists.txt b/rd-cpp/src/rd_framework_cpp/src/main/CMakeLists.txt
@@ -73,10 +73,14 @@ else ()
     add_library(rd_framework_cpp SHARED ${RD_FRAMEWORK_CPP_SOURCES})
 endif ()
 
+set(RD_FRAMEWORK_EXPORT_HEADER_CUSTOM_CONTENT "#include \"util/export_api_helper.h\"")
+
 include(GenerateExportHeader)
 generate_export_header(rd_framework_cpp
         BASE_NAME rd_framework
-        EXPORT_MACRO_NAME RD_FRAMEWORK_API)
+        EXPORT_MACRO_NAME RD_FRAMEWORK_API
+        CUSTOM_CONTENT_FROM_VARIABLE RD_FRAMEWORK_EXPORT_HEADER_CUSTOM_CONTENT
+)
 
 message(STATUS "Using pch by rd_framework: '${ENABLE_PCH_HEADERS}'")
 

diff --git a/rd-cpp/src/rd_framework_cpp/src/main/base/IProtocol.h b/rd-cpp/src/rd_framework_cpp/src/main/base/IProtocol.h
@@ -11,6 +11,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 // region predeclared
@@ -63,4 +65,6 @@ class RD_FRAMEWORK_API IProtocol : public IRdDynamic
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_IPROTOCOL_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/base/ISerializersOwner.h b/rd-cpp/src/rd_framework_cpp/src/main/base/ISerializersOwner.h
@@ -5,6 +5,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 // region predeclared
@@ -28,4 +30,6 @@ class RD_FRAMEWORK_API ISerializersOwner
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_ISERIALIZERSOWNER_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/base/IWire.h b/rd-cpp/src/rd_framework_cpp/src/main/base/IWire.h
@@ -7,6 +7,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 /**
@@ -44,4 +46,6 @@ class RD_FRAMEWORK_API IWire
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_IWIRE_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/base/RdBindableBase.h b/rd-cpp/src/rd_framework_cpp/src/main/base/RdBindableBase.h
@@ -8,6 +8,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class RD_FRAMEWORK_API RdBindableBase : public virtual IRdBindable /*, IPrintable*/
@@ -113,4 +115,6 @@ T& withIdFromName(T& that, std::string const& name)
 }
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_RDBINDABLEBASE_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/ext/ExtWire.h b/rd-cpp/src/rd_framework_cpp/src/main/ext/ExtWire.h
@@ -11,6 +11,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class RD_FRAMEWORK_API ExtWire final : public IWire
@@ -30,4 +32,6 @@ class RD_FRAMEWORK_API ExtWire final : public IWire
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_EXTWIRE_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/ext/RdExtBase.h b/rd-cpp/src/rd_framework_cpp/src/main/ext/RdExtBase.h
@@ -8,6 +8,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 /**
@@ -55,4 +57,6 @@ class RD_FRAMEWORK_API RdExtBase : public RdReactiveBase
 std::string to_string(RdExtBase::ExtState state);
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_RDEXTBASE_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/impl/RName.h b/rd-cpp/src/rd_framework_cpp/src/main/impl/RName.h
@@ -6,6 +6,8 @@
 #include <string>
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class RNameImpl;
@@ -47,4 +49,6 @@ class RD_FRAMEWORK_API RName
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_FRAMEWORK_RNAME_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/intern/InternRoot.h b/rd-cpp/src/rd_framework_cpp/src/main/intern/InternRoot.h
@@ -16,6 +16,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 // region predeclared
@@ -126,4 +128,6 @@ int32_t InternRoot::intern_value(Wrapper<T> value) const
 }
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_INTERNROOT_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/protocol/Buffer.h b/rd-cpp/src/rd_framework_cpp/src/main/protocol/Buffer.h
@@ -15,6 +15,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 /**
@@ -322,4 +324,6 @@ class RD_FRAMEWORK_API Buffer final
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_UNSAFEBUFFER_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/protocol/Identities.h b/rd-cpp/src/rd_framework_cpp/src/main/protocol/Identities.h
@@ -7,6 +7,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 /**
@@ -47,4 +49,6 @@ class RD_FRAMEWORK_API Identities
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_FRAMEWORK_IDENTITIES_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/protocol/MessageBroker.h b/rd-cpp/src/rd_framework_cpp/src/main/protocol/MessageBroker.h
@@ -11,6 +11,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 class RD_FRAMEWORK_API Mq
@@ -58,4 +60,6 @@ class RD_FRAMEWORK_API MessageBroker final
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_MESSAGEBROKER_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/protocol/Protocol.h b/rd-cpp/src/rd_framework_cpp/src/main/protocol/Protocol.h
@@ -9,6 +9,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 // region predeclared
@@ -55,4 +57,6 @@ class RD_FRAMEWORK_API Protocol : /*IRdDynamic, */ public IProtocol
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_PROTOCOL_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/scheduler/base/IScheduler.h b/rd-cpp/src/rd_framework_cpp/src/main/scheduler/base/IScheduler.h
@@ -6,6 +6,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 /**
@@ -53,4 +55,6 @@ class RD_FRAMEWORK_API IScheduler
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_ISCHEDULER_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/scheduler/base/SingleThreadSchedulerBase.h b/rd-cpp/src/rd_framework_cpp/src/main/scheduler/base/SingleThreadSchedulerBase.h
@@ -9,6 +9,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace ctpl
 {
 class thread_pool;
@@ -52,4 +54,6 @@ class RD_FRAMEWORK_API SingleThreadSchedulerBase : public IScheduler
 };
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_SINGLETHREADSCHEDULERBASE_H
diff --git a/rd-cpp/src/rd_framework_cpp/src/main/serialization/SerializationCtx.h b/rd-cpp/src/rd_framework_cpp/src/main/serialization/SerializationCtx.h
@@ -13,6 +13,8 @@
 
 #include <rd_framework_export.h>
 
+RD_PUSH_STL_EXPORTS_WARNINGS
+
 namespace rd
 {
 // region predeclared
@@ -101,4 +103,6 @@ void SerializationCtx::writeInterned(Buffer& buffer, const Wrapper<T>& value, F&
 }
 }	 // namespace rd
 
+RD_POP_STL_EXPORTS_WARNINGS
+
 #endif	  // RD_CPP_FRAMEWORK_SERIALIZATIONCTX_H