-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The big refactor — part 2 #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devkanro
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! but the CI broken...
* Fix dropdown menu and fallback rule * Fix tooltip * Fix tooltip * 🔀 Apply suggestions from code review Co-authored-by: Sebastiano Poggi <[email protected]> * 🔀 Apply suggestions from code review --------- Co-authored-by: Sebastiano Poggi <[email protected]>
rock3r
added a commit
that referenced
this pull request
Oct 24, 2023
* ButtonStyle refactor * CheckboxStyle refactor * ChipStyle refactor * CircularProgressStyle refactor * DividerStyle refactor * DropdownStyle refactor * GroupHeaderStyle refactor, simplify other styling * HorizontalProgressBarStyle refactor * IconButtonStyle refactor * LazyTreeStyle refactor * LinkStyle refactor * MenuStyle refactor * RadioButtonStyle refactor * ScrollbarStyle refactor * Fix IntUiButtonStyling * TabStyle refactor * InputFieldStyle & co refactor * TooltipStyle refactor * Update API dump * Fix dropdown menu and fallback rule (#194) * Fix dropdown menu and fallback rule * Fix tooltip * Fix tooltip * 🔀 Apply suggestions from code review Co-authored-by: Sebastiano Poggi <[email protected]> * 🔀 Apply suggestions from code review --------- Co-authored-by: Sebastiano Poggi <[email protected]> * Fix issues --------- Co-authored-by: Kanro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of the big refactor. It removes all the unnecessary interfaces and makes creating the standalone versions much easier.
This is a huge refactoring, but I have tested it as much as possible. We may have some issues slip through, but we're planning a bugfix 0.8.1 release by next week in case.